fix: the flake8 max line failure E501 and some other errors #2133
Conversation
| @@ -31,4 +31,4 @@ jobs: | |||
| run: | | |||
| python -m pip install --upgrade pip | |||
| pip install flake8 | |||
| flake8 --count --max-line-length=127 --statistics mslib tests | |||
| flake8 --count --statistics mslib tests | |||
There was a problem hiding this comment.
we don't run it on docs, see parameters.
There was a problem hiding this comment.
when you fixed docs now, then extend the parameters.
But I am not sure if that makes sense, when make docs is run, then other py scripts will become created below docs, which are automated done.
There was a problem hiding this comment.
What do i do now then?
There was a problem hiding this comment.
you did a bit too much, as in the "good first" issue was defined, read line 34, extend it to the docs dir too.
But when you do this the error will block its merging. so it must be solved too. And that gets then easily into not been a good first issue.
So leave it as it is.
There was a problem hiding this comment.
ok understood. actually its my first tym doing a contribution that way i got confused.
so here is the thing i think i should do now say yes and if i understood the assignment correctly.
i will fix all the issue in #2111 but this time from the stable branch.
and i will leave the python-flake8 file as it is
?
There was a problem hiding this comment.
don't touch the conf.py - no changes. Only remove the extra parameter from the CI file.
Look also in my comment in the slack channel
There was a problem hiding this comment.
the reason for good first issue, is to get a simple thing done, by learning the workflow. There bigger other issues later.
|
at this page https://open-mss.github.io/develop/GSOC/ideas i read that all bug fix go to stable branch that's why i did that😔 |
obviously you have not created a branch from stable but from develop. When you want to send it to stable, use the right branch from the beginning ;) A fix should not get all changes of develop into stable ;) |
|
Do you want to redo for stable? |
|
yes i can do that and only make changes in the work script ?? |
only this
|
|
Now we have 2 PR for this? |
|
yea but i closed it since in this the branch was created from develop and i did a bit too much so i redid from stable |
|
Ok |
Purpose of PR?:
Fixes #2111
If the changes in this PR are manually verified, list down the scenarios covered::
Before
After
Checklist:
This pull request addresses several flake8 errors and undefined name issues in the codebase. I have adjusted the indentation, comments, and variable definitions to comply with the flake8 style guide. Additionally, i removed the max-line-length = 127 from the python-flake8 because it was overwriting setup.cfg. These changes ensure that the codebase adheres to the project's coding standards and resolves the reported issues.